Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving the protections toggle on primary screen #2321

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Moving the protections toggle on primary screen #2321

merged 1 commit into from
Nov 16, 2023

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Nov 6, 2023 •
edited

https://app.asana.com/0/0/1205883650709863/f

Reviewer: @sammacbeth

Description:

  • Moved the toggle to the top of the primary screen

extensions.jpeg

Steps to test this PR:

  • tapping on 'website not working?' should reveal the breakage form as normal

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@shakyShane
Copy link
Contributor Author

shakyShane commented Nov 6, 2023 •
edited

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@shakyShane shakyShane marked this pull request as ready for review November 13, 2023 19:42
@shakyShane shakyShane merged commit 644a3ae into main Nov 16, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sammacbeth sammacbeth sammacbeth approved these changes

Assignees

@sammacbeth sammacbeth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shakyShane @sammacbeth