Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip #160

Merged
merged 6 commits into from
Jul 22, 2024
Merged

wip #160

merged 6 commits into from
Jul 22, 2024

Conversation

kotbegemot
Copy link
Member

No description provided.

CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Outdated
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /GR-")
endif ()

else (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
...
else (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")

What is this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looks odd.

CMakeLists.txt Outdated
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /GR-")
endif ()

else (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
else (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
else

?

@SergeiNA SergeiNA merged commit 0176910 into master Jul 22, 2024
158 checks passed
@SergeiNA SergeiNA deleted the cmake-add-flags branch July 22, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants