Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

Deprecate simple attribute specification in BadKwargUseLinter #19

Closed
mschwager opened this issue Sep 16, 2019 · 0 comments
Closed

Deprecate simple attribute specification in BadKwargUseLinter #19

mschwager opened this issue Sep 16, 2019 · 0 comments

Comments

@mschwager
Copy link
Collaborator

BadKwargUseLinter has been improved to allow specifying full module paths instead of just attributes. E.g. subprocess.Popen vs. Popen. This allows us to more accurately describe the attributes with insecure kwarg behavior. To ensure backwards compatibility we still support the previous behavior. We should deprecate and eventually remove the old behavior as it can be more accurately specified using the new behavior. We're deprecating and then removing because third-party custom plugins may depend on the previous behavior.

This work should include:

  • Possibly renaming attribute_name to something new like module_path.
  • Include DeprecationWarning for old name/behavior.
  • Update first-party linters that inherit from BadKwargUseLinter.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant