Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the used block gas limit into the block header #1416

Closed
herr-seppia opened this issue Jun 15, 2022 · 0 comments · Fixed by #1417
Closed

Include the used block gas limit into the block header #1416

herr-seppia opened this issue Jun 15, 2022 · 0 comments · Fixed by #1417
Assignees

Comments

@herr-seppia
Copy link
Member

Describe "Why" this is needed
The blockgaslimit used to produce a block should be decided by the block producer.
In order to let the network validate a block properly, this info should be carried by the block itself so that a verifier can use that limit to validate a block

Describe alternatives you've considered
N/A

Additional context
At the moment of writing the block gas limit is hardcoded. This obviously raise a resync problem when a new node join the network after being compiled with a different block gas limit value.
The current hardcoded value should be moved to a configuration value and used as GasLimit only when producing a block.
A further optimisation at verifier side can be to discard any block with gasSpent higher than the gas limit configured

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant