Add taskflow #67
Closed
Add taskflow #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"make all" seems to succeed about 75% of the time, but the rest causes a seg-fault |
arcondello
reviewed
Dec 6, 2022
| @@ -148,6 +156,10 @@ class Presolver { | |||
| const Postsolver<bias_type, index_type, assignment_type>& postsolver() const; | |||
|
|
|||
| private: | |||
| tf::Taskflow taskflowOneTime_; | |||
There was a problem hiding this comment.
why break these into three rather than one big flow?
There was a problem hiding this comment.
That's mostly for a logical separation of the 3 different "types" of techniques. I'll do some more reading on the pros/cons and leave a note in the code either way.
…nto there; ie, the old-way no longer exists. Also, note that TF is currently still running serially
…t seems to be resolving the seg-faults I was seeing
…eption outside of the TF tasks
|
Splitting changes into distinct PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.