Use positive_permissions.set()

Direct assignment to the forward side of a many-to-many set is deprecated
due to the implicit save() that happens. Use positive_permissions.set()
instead.

pootle/core/initdb.py

@@ -73,7 +73,7 @@ def _create_pootle_permission_set(self, permissions, **criteria):
         permission_set, created = self._create_object(PermissionSet,
                                                       **criteria)
         if created:
-            permission_set.positive_permissions = permissions
+            permission_set.positive_permissions.set(permissions)
             permission_set.save()
         return permission_set
 

pytest_pootle/fixtures/models/permission_set.py

@@ -18,9 +18,9 @@ def _require_permission_set(user, directory, positive_permissions=None,
     }
     permission_set = PermissionSet.objects.get_or_create(**criteria)[0]
     if positive_permissions is not None:
-        permission_set.positive_permissions = positive_permissions
+        permission_set.positive_permissions.set(positive_permissions)
     if negative_permissions is not None:
-        permission_set.negative_permissions = negative_permissions
+        permission_set.negative_permissions.set(negative_permissions)
 
     permission_set.save()
 

tests/models/user.py

@@ -458,7 +458,7 @@ def test_user_has_manager_permissions(no_perms_user, administrate, tp0):
         'directory': tp0.directory,
     }
     ps = PermissionSet.objects.get_or_create(**criteria)[0]
-    ps.positive_permissions = [administrate]
+    ps.positive_permissions.set([administrate])
     ps.save()
     assert no_perms_user.has_manager_permissions()
     ps.positive_permissions.clear()
@@ -467,7 +467,7 @@ def test_user_has_manager_permissions(no_perms_user, administrate, tp0):
     # Assign 'administrate' right for 'Language0' and check user is manager.
     criteria['directory'] = language0.directory
     ps = PermissionSet.objects.get_or_create(**criteria)[0]
-    ps.positive_permissions = [administrate]
+    ps.positive_permissions.set([administrate])
     ps.save()
     assert no_perms_user.has_manager_permissions()
     ps.positive_permissions.clear()
@@ -476,7 +476,7 @@ def test_user_has_manager_permissions(no_perms_user, administrate, tp0):
     # Assign 'administrate' right for 'Project0' and check user is manager.
     criteria['directory'] = project0.directory
     ps = PermissionSet.objects.get_or_create(**criteria)[0]
-    ps.positive_permissions = [administrate]
+    ps.positive_permissions.set([administrate])
     ps.save()
     assert no_perms_user.has_manager_permissions()
     ps.positive_permissions.clear()
@@ -502,7 +502,7 @@ def test_get_users_with_permission(default, member, translate):
     # remove "Can submit translation" permission for default user
     ps = PermissionSet.objects.filter(user=default,
                                       directory=Directory.objects.root)[0]
-    ps.positive_permissions = ps.positive_permissions.exclude(id=translate.id)
+    ps.positive_permissions.set(ps.positive_permissions.exclude(id=translate.id))
     ps.save()
     users = User.objects.get_users_with_permission('translate', project, language)
     for user in users:

tests/views/admin.py

@@ -162,7 +162,7 @@ def test_admin_view_project_manager(client, member, administrate):
         'user': member,
         'directory': project.directory}
     ps = PermissionSet.objects.create(**criteria)
-    ps.positive_permissions = [administrate]
+    ps.positive_permissions.set([administrate])
     client.login(
         username=member.username,
         password=TEST_USERS[member.username]["password"])