Fixes mbnavadjust crash and crash on Windows writing GMT grids #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed test/utilities/Makefile.in so that the CI test log will cat the log files for the tests of mbbackangle, mbgrid, and mbprocess. These are failing in one of the Travis-CI test builds - the one for Ubuntu Xenial. All other test builds succeed, and the reason for the one failure is unknown for lack of access to the failed test output.
Mbnavadjust: Fixed crash on Linux when executing the Auto Set Vertical Offset function (didn't dimension arrays large enough). Writing GMT grids: Fixed crash reported by Joaquim Luis on Windows when writing GMT grids - the problem was a function call that caused GDAL to allocate a string but then it allowing that pointer to be freed in GMT functions. The solution is to copy the string and free the pointer using a GDAL call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mbnavadjust: Fixed crash on Linux when executing the Auto Set Vertical Offset
function (didn't dimension arrays large enough).
Writing GMT grids: Fixed crash reported by Joaquim Luis on Windows when writing
GMT grids - the problem was a function call that caused GDAL to allocate a string
but then it allowing that pointer to be freed in GMT functions. The solution is
to copy the string and free the pointer using a GDAL call.