Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page refresh should allow existing timers to continue running #91

Closed
iteles opened this issue Apr 3, 2015 · 11 comments
Closed

Page refresh should allow existing timers to continue running #91

iteles opened this issue Apr 3, 2015 · 11 comments
Assignees
Labels
enhancement New feature or enhancement of existing functionality MVP
Milestone

Comments

@iteles
Copy link
Member

iteles commented Apr 3, 2015

For both anonymous and logged in people.

I think this needs to be an MVP feature because the people we will be lucky enough to have as our alpha users will be opening and closing tabs all the time!

@iteles iteles added enhancement New feature or enhancement of existing functionality MVP FrontEnd labels Apr 3, 2015
@nelsonic
Copy link
Member

nelsonic commented Apr 3, 2015

Agree. will get this done today. 👍

@nelsonic nelsonic self-assigned this Apr 3, 2015
@iteles iteles modified the milestone: MVP Apr 9, 2015
@nelsonic
Copy link
Member

@iteles should the timers be stored on the client (Offline: #35) or should just the session token be stored on the client and we send a GET /timer/all query during boot?
(one is a lot faster_er_ but means we don't fetch any timers that were created on a diff device/browser) ...

_Or... do we load from localStorage and _also GET /timer/all and re-render if there are more timers on the server than on the device...?

@nelsonic
Copy link
Member

Need to get Login #106 working
then add a GET /timers/all request in loadtimers to ensure we fetch timers from the server if the person is logged in.

@nelsonic
Copy link
Member

@iteles please test and close if happy.

@nelsonic nelsonic assigned iteles and unassigned nelsonic Apr 12, 2015
@iteles
Copy link
Member Author

iteles commented Apr 12, 2015

Works perfectly, both the timer keeps running AND any description already entered into the active timer re-appears. 👍 😊

@iteles iteles closed this as completed Apr 12, 2015
@nelsonic nelsonic reopened this Apr 12, 2015
@nelsonic
Copy link
Member

But... any previous timers (from an earlier session) were not being show (once the person logged in)...

@nelsonic
Copy link
Member

@iteles Works now. steps to test this are:

  • create timer as anon
  • register
  • create more timers
  • refresh
  • logout
  • refresh
  • create new timer
  • refresh
  • login
  • refresh
    😉

@iteles
Copy link
Member Author

iteles commented Apr 12, 2015

I was still thinking along the lines of anonymous timers 😊
Caught another bug whilst testing this one: #122

Shall we call this one closed and leave the other issue to capture the remaining work @nelsonic?

@nelsonic
Copy link
Member

_Nothing_ "Works" until _Everything_ (just) Works!
Investigating #122 now. 👍

@nelsonic
Copy link
Member

@iteles do you have time to re-test this now?

@iteles
Copy link
Member Author

iteles commented Apr 13, 2015

Seems to be working well 👍

@iteles iteles closed this as completed Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement of existing functionality MVP
Projects
None yet
Development

No branches or pull requests

2 participants