Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialise Flutter application #302

Merged
merged 12 commits into from
Feb 20, 2023
Merged

Initialise Flutter application #302

merged 12 commits into from
Feb 20, 2023

Conversation

SimonLab
Copy link
Member

@SimonLab SimonLab commented Feb 1, 2023

  • Run flutter create . to create a new flutter application on the current folder
  • Update the existing .gitignore file with the one created by the flutter command
  • Add widget to enter item text similar to a textarea. Look in detail which widget to use and its configuration to have a nice UI

- Run `flutter create .` to create a new flutter application on the
  current folder
- Update the existing .gitignore file with the one created by the
  flutter command
@SimonLab SimonLab added the in-progress An issue or pull request that is being worked on by the assigned person label Feb 1, 2023
@SimonLab SimonLab self-assigned this Feb 1, 2023
@SimonLab
Copy link
Member Author

SimonLab commented Feb 2, 2023

Working on the layout of the widgets. Looking also at hiding/showing list of items when the text field has focused:
image

- dispalye textField and list of items
- Attempt to expands the textField
@nelsonic
Copy link
Member

nelsonic commented Feb 2, 2023

Thanks for proactively looking at this @SimonLab 👍

Wrap TextField widget in a Focus widget to be able to use the
onFocusChange callback.

see #308
@nelsonic
Copy link
Member

@SimonLab do you feel like this is at a point where it can be reviewed & merged into main
as the starting point for the App? or are you still working on the TextField? 💭

Asking because the work @LuchoTurtle did for the Basic Nav #305 should be ready to integrate into the App now and I was going to suggest he do it Today. 🤞

@nelsonic nelsonic mentioned this pull request Feb 20, 2023
4 tasks
Commend list of items to unblock Luis
@SimonLab SimonLab added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Feb 20, 2023
@SimonLab SimonLab assigned nelsonic and LuchoTurtle and unassigned SimonLab Feb 20, 2023
@SimonLab
Copy link
Member Author

To unblock the work from @LuchoTurtle I think we can merge this PR.
I'll add the layout for the items on the next PR with doc and tests

@SimonLab SimonLab marked this pull request as ready for review February 20, 2023 10:06
@LuchoTurtle
Copy link
Member

Will check the code. Just waiting for VSCode to download everything. I needed to run flutter upgrade because I was using an older version.

@LuchoTurtle
Copy link
Member

The test is failing. I'm going to create a simple setup one with CI so this PR already has a pipeline when merged 🙂

- package-ecosystem: mix
directory: "/"
schedule:
interval: daily
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can make the interval weekly. We have a lot of notifications for updating the dependencies on the repositories and this creates a lot of noise. But happy to keep it daily on specific repositories too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure if this should be daily or weekly for this repo. While this repo is in active development we might want to keep it daily, I was more thinking of other "stable" repos.
We can change this back on the next PRs if required

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this open for @nelsonic to comment. I'll change it back to daily, meanwhile.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally happy with Weekly for the demo/example. Agree that it's noisy. Let's start changing the frequency gradually on all those our repos. However on the App and Auth we want daily to for security updates. 💭

@LuchoTurtle
Copy link
Member

LuchoTurtle commented Feb 20, 2023

To get this merged ASAP, lgtm!

Coverage is not 100% (it's still being developed by you, you can get it up in a different branch) and the README will obviously be extended. But for now, it's good to start to get some work on, I wager.

Thanks @SimonLab 🎉


defaultConfig {
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
applicationId "com.example.app"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many instances of "com.example.app" in this PR.
We need to update them all to "com.dwyl.app"
see: #312

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SimonLab looks good. 👍
Follow-up issue: #312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants