Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Adding splash screen #321

Merged
merged 5 commits into from
Mar 2, 2023
Merged

[PR] Adding splash screen #321

merged 5 commits into from
Mar 2, 2023

Conversation

LuchoTurtle
Copy link
Member

closes #319

Adds a basic loading screen with no animations and according to the design guidelines detailed in #319.

@LuchoTurtle LuchoTurtle added enhancement New feature or enhancement of existing functionality in-progress An issue or pull request that is being worked on by the assigned person flutter Flutter related issues labels Mar 1, 2023
@LuchoTurtle LuchoTurtle self-assigned this Mar 1, 2023
@LuchoTurtle
Copy link
Member Author

Should be able to see this

image

@LuchoTurtle LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Mar 1, 2023
@LuchoTurtle LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Mar 1, 2023
nelsonic
nelsonic previously approved these changes Mar 2, 2023
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LuchoTurtle 👌
Removed a couple of things that weren't in #319 ✂️
But otherwise. great. 🚀

image

Compressed/Minified CSS: 🏎️
https://blog.logrocket.com/best-practices-improving-css-performance/#compress-css

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging. :shipit:

@nelsonic nelsonic merged commit 7a5524e into main Mar 2, 2023
@nelsonic nelsonic deleted the loading_fix#319 branch March 2, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed enhancement New feature or enhancement of existing functionality flutter Flutter related issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Feat: Loading Screen
2 participants