[bug] Fix speed up patch file on service worker #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuchoTurtle
added
bug
|
@nelsonic please review and merge. If the build and deploy works, it should mitigate the issue in #333 . If it looks good, please review and merge dwyl/learn-flutter#92 , it does the same changes to our guide on |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #333
Checking the file after the patch, it seems that a variable wasn't correctly initialized.
This should fix the issue facing in #333.
If correctly merged, we should do the same in the
dwyl/learn-flutterrepo as well.