Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR] Clarify expected binary but got nil error #267

Merged
merged 1 commit into from
Jul 27, 2024
Merged

[PR] Clarify expected binary but got nil error #267

merged 1 commit into from
Jul 27, 2024

Conversation

LuchoTurtle
Copy link
Member

closes #266

@LuchoTurtle LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed documentation Improvements or additions to documentation labels Feb 2, 2023
@LuchoTurtle LuchoTurtle assigned LuchoTurtle and unassigned nelsonic Feb 2, 2023
@LuchoTurtle LuchoTurtle added in-progress An issue or pull request that is being worked on by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Feb 2, 2023
@nelsonic
Copy link
Member

@LuchoTurtle no merge conflicts on this PR. Can I merge it? 💭

@LuchoTurtle
Copy link
Member Author

@nelsonic go for it

@LuchoTurtle LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Jul 27, 2024
@nelsonic
Copy link
Member

Thanks chief! 🙏

nelsonic
nelsonic approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying this in the docs. 🙏

@nelsonic nelsonic merged commit cbeedac into main Jul 27, 2024
@nelsonic nelsonic deleted the fix-#266 branch July 27, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@LuchoTurtle LuchoTurtle

Labels
awaiting-review An issue or pull request that needs to be reviewed documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error expected a binary but got: nil
2 participants
@LuchoTurtle @nelsonic