-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Update to Node.js v20
#85
#92
Conversation
Added it to: https://github.com/dwyl/aws-lambda-deploy/settings/secrets/actions Gonna re-run the build ... |
Gonna have to come back to this ... debugging GitHub CI is super tedious ... 🙄 |
This is such a time-suck. I would gladly pay someone |
I think this is a "New Node" throwing an error where it didn't before ... 💭 |
…js as throwing unrecoverable error for no reason ... #85
Tests fail because function already exists: Think I'm going to side-step this issue by only testing on one version of |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 7
Lines ? 136
Branches ? 0
========================================
Hits ? 136
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Tests passing. Going to try to re-enable the |
Nope. Race condition when running the tests in parallel. 🙄 |
OK. I'm at the point where I'm "happy" with this. Going to bump the version and publish. 📦 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👌
This is a much-needed update to:
So that we can continue deploying Lambda Functions for the next couple of years.
Also: