Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the project meant to be called Ric and can it be changed so something else? #22

Closed
RobStallion opened this issue Jan 28, 2019 · 3 comments
Assignees
Labels
question Further information is requested T25m

Comments

@RobStallion
Copy link
Member

Is the project meant to be called Ric and can it be changed so something else? I was thinking ex_cid.

Reason for wanting to change it is so that if we use ex_cid as a dependency we do not get any errors with modules/files having the same names (why I changed filenames in this commit).

See following link...
https://github.com/dwyl/cid/blob/master/mix.exs#L1-L6

@RobStallion RobStallion added question Further information is requested T25m labels Jan 28, 2019
@nelsonic
Copy link
Member

@RobStallion did you mean "rid"? (the original name being "Resource ID" ...)
Yes, all instances of Rid should be changed to Cid.

@nelsonic nelsonic removed their assignment Jan 28, 2019
@RobStallion
Copy link
Member Author

RobStallion commented Jan 28, 2019

🤦‍♂️ I typo-ed what I thought was a typo. Thanks for the quick response 👍

@nelsonic With regards to...

Yes, all instances of Rid should be changed to Cid.

This will cause a conflict with the ex_cid module that I am using as a dependency as it's main module is also called CID?

I have named our module ex_cid for the time being but change to something else if anyone has another suggestion. (also if and when we build our own version of the functions provided by ex_cid and it's list of deps (see #19) we can change the name back to CID without consequence)

@RobStallion RobStallion reopened this Jan 28, 2019
RobStallion added a commit that referenced this issue Jan 28, 2019
@RobStallion RobStallion mentioned this issue Jan 28, 2019
RobStallion added a commit that referenced this issue Jan 28, 2019
RobStallion added a commit that referenced this issue Jan 28, 2019
@RobStallion
Copy link
Member Author

@nelsonic answered my next question with this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested T25m
Projects
None yet
Development

No branches or pull requests

2 participants