Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What? #14

Closed
wants to merge 1 commit into from
Closed

What? #14

wants to merge 1 commit into from

Conversation

SimonLab
Copy link
Member

ref: #13

@SimonLab SimonLab self-assigned this Jan 21, 2019
nelsonic
nelsonic approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab good additions. please assign when you feel it's mergeable. 👍

@nelsonic nelsonic added the enhancement New feature or request label Jan 24, 2019
@nelsonic nelsonic added the help wanted Extra attention is needed label Jan 30, 2019
@SimonLab
Copy link
Member Author

SimonLab commented Feb 1, 2019

I'm closing this PR as what I wrote was more based on my understand of how a CID is build but these are technical details and the Readme is not the best place to describe technical implementation.
see #13 (comment)

@SimonLab SimonLab closed this Feb 1, 2019
@SimonLab SimonLab deleted the what-are-CIDs branch February 1, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@SimonLab SimonLab

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonLab @nelsonic