Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unknown build issue #40 #41

Merged
merged 17 commits into from
Aug 23, 2023
Merged

Fix unknown build issue #40 #41

merged 17 commits into from
Aug 23, 2023

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Aug 23, 2023

Fixes a bunch of issues in the README.md and build. ✅

@nelsonic nelsonic mentioned this pull request Aug 23, 2023
5 tasks
@nelsonic nelsonic added awaiting-review T5m Task that takes 5 minutes to complete. labels Aug 23, 2023
@nelsonic nelsonic requested a review from asntc August 23, 2023 21:24
asntc
asntc previously approved these changes Aug 23, 2023
Copy link
Member

@asntc asntc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Copy link
Member

@asntc asntc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@asntc asntc merged commit 3b94880 into main Aug 23, 2023
1 check passed
@asntc asntc deleted the fix-unknown-build-issue-#40 branch August 23, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review T5m Task that takes 5 minutes to complete.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants