Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript Suport (Fix #41) #45

Merged
merged 1 commit into from
Jan 20, 2019
Merged

Typescript Suport (Fix #41) #45

merged 1 commit into from
Jan 20, 2019

Conversation

mathe42
Copy link
Contributor

@mathe42 mathe42 commented Jan 20, 2019

I added an additional export to export it as default as in .d.ts defined.

I don't know how to properly change the .d.ts file such that it works with

import * as decache from 'decache'

Now you can import it with

import decache from 'decache'

Export it as default
@codecov
Copy link

codecov bot commented Jan 20, 2019

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #45   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          47     48    +1     
  Branches        6      6           
=====================================
+ Hits           47     48    +1
Impacted Files Coverage Δ
decache.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30007d2...fc5b6b0. Read the comment docs.

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathe42 thanks for adding this line to fix #41 🥇

@nelsonic nelsonic merged commit 6c51678 into dwyl:master Jan 20, 2019
@nelsonic
Copy link
Member

decache@4.5.1 published. :shipit:
thanks again for your help Sebastian. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants