Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GitHub Actions (CI) and Tidy up badges issue #52 #53

Merged
merged 9 commits into from
Nov 27, 2021
Merged

Use GitHub Actions (CI) and Tidy up badges issue #52 #53

merged 9 commits into from
Nov 27, 2021

Conversation

nelsonic
Copy link
Member

Ref #52

@nelsonic nelsonic added the in-progress An issue or pull request that is being worked on by the assigned person label Nov 26, 2021
@nelsonic nelsonic self-assigned this Nov 26, 2021
@nelsonic
Copy link
Member Author

Badges tidy: https://github.com/dwyl/decache/blob/36e9a6ea88bd2295f1c1761c2fa769540d87e66b/README.md
image

Or the will once the PR is merged and there is a build on main ... for now the Build badge looks like this:
image

@SimonLab could you look at why the GitHub Action CI script isn't running for this PR/project? 🙏
I'm missing something and I cannot see what ... 🤷‍♂️

@nelsonic nelsonic assigned SimonLab and unassigned nelsonic Nov 26, 2021
@nelsonic nelsonic added help wanted If you can help make progress with this issue, please comment! priority-3 Third priority. Considered "Nice to Have". Not urgent. labels Nov 26, 2021
@nelsonic
Copy link
Member Author

Totally not "urgent". Thanks!

@nelsonic nelsonic mentioned this pull request Nov 26, 2021
Closed
7 tasks
SimonLab
SimonLab reviewed Nov 26, 2021
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@nelsonic @SimonLab
replace "master" with "main" in .github/workflows/ci.yml for #52
d0e648d 
Co-authored-by: Simon <simon.labondance@gmail.com>
@codecov
Copy link

codecov bot commented Nov 26, 2021 •
edited
Loading

Codecov Report

Merging #53 (8fefa5f) into main (593197b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #53   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           48        48           
=========================================
  Hits            48        48

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 593197b...8fefa5f. Read the comment docs.

@nelsonic nelsonic added awaiting-review An issue or pull request that needs to be reviewed and removed help wanted If you can help make progress with this issue, please comment! in-progress An issue or pull request that is being worked on by the assigned person labels Nov 26, 2021
@nelsonic
Copy link
Member Author

@SimonLab thanks for fixing the CI YAML file (branch name). 🥇
Please review + merge when you can (still not urgent). Thanks! ☀️

SimonLab
SimonLab approved these changes Nov 27, 2021
View reviewed changes
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SimonLab SimonLab merged commit 95e631f into main Nov 27, 2021
@SimonLab SimonLab deleted the tidy-up-badges-issue-#52 branch November 27, 2021 13:12
@nelsonic
Copy link
Member Author

nelsonic commented Dec 2, 2021

decache@4.6.1 published to NPM. 📦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonLab SimonLab SimonLab approved these changes

Assignees

@SimonLab SimonLab

Labels
awaiting-review An issue or pull request that needs to be reviewed priority-3 Third priority. Considered "Nice to Have". Not urgent.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @SimonLab