Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Tidy up, Update & Create Table of Contents #47 #48

Merged
merged 8 commits into from
Aug 9, 2022
Merged

PR: Tidy up, Update & Create Table of Contents #47 #48

merged 8 commits into from
Aug 9, 2022

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Jul 25, 2022 •
edited
Loading

@nelsonic nelsonic added chore a tedious but necessary task often paying technical debt in-progress An issue or pull request that is being worked on by the assigned person labels Jul 25, 2022
@nelsonic nelsonic self-assigned this Jul 25, 2022
@nelsonic nelsonic added the priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished label Jul 25, 2022
@nelsonic nelsonic removed the in-progress An issue or pull request that is being worked on by the assigned person label Jul 27, 2022
@nelsonic nelsonic mentioned this pull request Jul 27, 2022
Open
@nelsonic nelsonic assigned SimonLab and unassigned nelsonic Jul 31, 2022
@nelsonic nelsonic added the awaiting-review An issue or pull request that needs to be reviewed label Jul 31, 2022
@nelsonic
Copy link
Member Author

@SimonLab definitely no rush. Just when you have a break. Thanks. 🙏

@nelsonic nelsonic changed the title WiP PR: Tidy up, Update & Create Table of Contents #47 PR: Tidy up, Update & Create Table of Contents #47 Aug 8, 2022
SimonLab
SimonLab reviewed Aug 8, 2022
View reviewed changes
readme.md Outdated Show resolved Hide resolved
SimonLab
SimonLab reviewed Aug 8, 2022
View reviewed changes
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few fixes on typos

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@SimonLab SimonLab assigned nelsonic and unassigned SimonLab Aug 8, 2022
@nelsonic @SimonLab
Apply suggestions from code review [typo fixes ... thanks @SimonLabon…
44c67df 
…dance! #45 ...]

Co-authored-by: Simon <simon.labondance@gmail.com>
nelsonic
nelsonic commented Aug 8, 2022
View reviewed changes
Copy link
Member Author

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci @SimonLab 👌

@nelsonic nelsonic requested a review from SimonLab August 8, 2022 14:44
@nelsonic nelsonic assigned SimonLab and unassigned nelsonic Aug 8, 2022
SimonLab
SimonLab approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SimonLab SimonLab merged commit 9432b34 into master Aug 9, 2022
@SimonLab SimonLab deleted the tidy-update-toc-#47 branch August 9, 2022 08:25
@nelsonic nelsonic mentioned this pull request Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonLab SimonLab SimonLab approved these changes

Assignees

@SimonLab SimonLab

Labels
awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @SimonLab