Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets up welcome page #48

Merged
merged 8 commits into from
Nov 1, 2015
Merged

Sets up welcome page #48

merged 8 commits into from
Nov 1, 2015

Conversation

iteles
Copy link
Member

@iteles iteles commented Oct 29, 2015

Fixes some minor CSS issue in main.css but mostly adds a proposed variation /welcome.html with an 'Our Story' section for A/B testing.

The whole variation is in separate files (welcome.html and welcome.css) so won't affect the main site for now apart from fixing a little CSS.

@nelsonic The text in the variation most likely needs revising.

@nelsonic
Copy link
Member

is this still "WIP" or have you assigned it to me for review/merge? ❓

@iteles
Copy link
Member Author

iteles commented Oct 30, 2015

@nelsonic I only assign something when it's ready to be reviewed/discussed and eventually merged.

Please review if you can, not a huge rush and I'm happy to talk you through the highlights to speed up the process. Just let me know.

@nelsonic
Copy link
Member

Right... but, leaving the word "WIP" as the only description for the PR suggests it's not "ready"...

@iteles
Copy link
Member Author

iteles commented Oct 30, 2015

@nelsonic Must not have updated on your end, apologies.

I always update the description fully before assigning/asking for a review. Should look like this:
screen shot 2015-10-30 at 14 42 59

@nelsonic
Copy link
Member

nelsonic commented Nov 1, 2015

Merging to show evo in project history. but we do need a #51

nelsonic added a commit that referenced this pull request Nov 1, 2015
@nelsonic nelsonic merged commit 578f81e into master Nov 1, 2015
@nelsonic nelsonic deleted the welcome branch November 1, 2015 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants