Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Contact form SPAM #487 #500

Merged
merged 7 commits into from
Jan 19, 2023
Merged

Resolve Contact form SPAM #487 #500

merged 7 commits into from
Jan 19, 2023

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Jan 19, 2023 •
edited
Loading

This PR:

  • removes all instances of the contact us form which were generating 99% SPAM emails Contact Form SPAM 😢  #487
    (people can - and do - still contact us directly using the email address, just not bots using this <form>!!)
  • Remove links to stale pages
  • Remove .travis.yml and add .github for CI/dependabot
  • Manually lint the JS code to keep eslint happy.
  • Update <footer> to copyright 2023

This whole site will eventually be superseded by #493 ⏳
But until then we need to avoid the daily barrage of SPAM emails. 👎

@nelsonic nelsonic added T25m Time Estimate 25 Minutes chore a tedious but necessary task often paying technical debt awaiting-review An issue or pull request that needs to be reviewed labels Jan 19, 2023
@nelsonic nelsonic mentioned this pull request Jan 19, 2023
Closed
1 task
SimonLab
SimonLab reviewed Jan 19, 2023
View reviewed changes
package.json
@@ -6,7 +6,7 @@
"scripts": {
"test": "tape test/*.test.js",
"dev": "live-server --port=8000",
"dev:alt": "serve -l 8000",
"serve": "serve -l 8000",
"test:dev": "tape ./redesign/test/*.test.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see the redesign folder in the proejct, so the test:dev command won't run any tests either

SimonLab
SimonLab approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think there are a few things that can be cleaned but this can be review with #493

@SimonLab SimonLab merged commit 9158a08 into master Jan 19, 2023
@SimonLab SimonLab deleted the contact-form-spam-#487 branch January 19, 2023 09:57
@nelsonic
Copy link
Member Author

Thanks @SimonLab 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonLab SimonLab SimonLab approved these changes

Assignees

@SimonLab SimonLab

Labels
awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt T25m Time Estimate 25 Minutes
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @SimonLab