Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: replace google analytics with plausbile/analytics #503

Merged
merged 30 commits into from
Feb 11, 2023
Merged

PR: replace google analytics with plausbile/analytics #503

merged 30 commits into from
Feb 11, 2023

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Feb 7, 2023

@nelsonic nelsonic added the awaiting-review An issue or pull request that needs to be reviewed label Feb 7, 2023
@nelsonic nelsonic requested a review from iteles February 7, 2023 15:16
@nelsonic
Copy link
Member Author

nelsonic commented Feb 7, 2023

@iteles this is just the same change applied to multiple pages. ⏳
Should be a quick review. Please merge if you're happy. 🙏 :shipit:

@nelsonic
Copy link
Member Author

nelsonic commented Feb 7, 2023

Forced to add package-lock.json to GitHub otherwise CI won't pass ...
see: https://github.com/dwyl/dwyl-site/actions/runs/4115415521/jobs/7104093644#step:3:12 🙄

@nelsonic
Copy link
Member Author

nelsonic commented Feb 7, 2023

BS error about package.json not being valid:
https://github.com/dwyl/dwyl-site/actions/runs/4115464567/jobs/7104208455#step:4:7
image

Validated on: https://jsonlint.com

image

lame.

@nelsonic
Copy link
Member Author

nelsonic commented Feb 7, 2023

This is utter garbage. jsonlint passes on localhost!!
https://github.com/dwyl/dwyl-site/actions/runs/4115564649/jobs/7104443184#step:4:11
image

@nelsonic
Copy link
Member Author

nelsonic commented Feb 7, 2023

Planning a slight update to this ... looking at: https://pypi.org/project/html5validator/

@nelsonic
Copy link
Member Author

nelsonic commented Feb 7, 2023

https://github.com/marketplace/actions/html5-validator

@nelsonic
Copy link
Member Author

nelsonic commented Feb 7, 2023

Completely removed package.json as it wasn't parsing no matter what I did!
Still get this silly merge conflict blocking the PR:

image

@nelsonic
Copy link
Member Author

nelsonic commented Feb 7, 2023

@iteles please merge when you can so we can test the analytics. thanks. 👌

@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. labels Feb 9, 2023
@nelsonic nelsonic mentioned this pull request Feb 10, 2023
Closed
iteles
iteles approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nelsonic , keen to see how this works 👌

404.html
<li class="ph4 di-l pv2 tl pv0-l"><a href="/values" class="dwyl-dark-gray link">Values</a></li>
<li class="ph4 di-l pv2 tl pv0-l"><a href="/team" class="dwyl-dark-gray link">Team</a></li>
<li class="ph4 dib-l pv2 tl pv0-l"><a href="/time-app" class="dwyl-dark-gray link">App
<li class="ph4 di-l pv2 tl pv0-l"><a href="/portfolio.html" class="dwyl-dark-gray link">Portfolio</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that we had to add these in 👍

blog.html
@@ -37,12 +30,9 @@
<meta name="msapplication-TileImage" content="/img/ms-icon-144x144.png">
<meta name="theme-color" content="#ffffff">
<title>The Blog | Web Development, Agile Methodologies and more | dwyl</title>
<script defer data-domain="dwyl.com" src="https://plausible.io/js/script.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iteles iteles merged commit 3037e5f into main Feb 11, 2023
@iteles iteles deleted the replace-google-analytics-with-plausible branch February 11, 2023 14:20
@nelsonic
Copy link
Member Author

@iteles see: https://plausible.io/dwyl.com 📈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iteles iteles iteles approved these changes

Assignees

@iteles iteles

Labels
awaiting-review An issue or pull request that needs to be reviewed enhancement New feature or enhancement of existing functionality T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule.
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @iteles