Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme with list of rules and comments #105

Closed
SimonLab opened this issue Jun 20, 2017 · 12 comments
Closed

update readme with list of rules and comments #105

SimonLab opened this issue Jun 20, 2017 · 12 comments

Comments

@SimonLab
Copy link
Member

To let the users which rules is implemented and what are the action dwylbot applied to the issues/PRs we need to update the readme with

  • list of rules
  • list of comments,
  • list of labels added, removed
    -l inks to the rule issue
@ghost
Copy link

ghost commented Jun 20, 2017

@SimonLab if you paste in the code here for the rules I can translate to writing and update the readme

@ghost ghost assigned SimonLab Jun 20, 2017
@iteles
Copy link
Member

iteles commented Jun 20, 2017

@markwilliamfirth I'm thinking we could spread the code knowledge across the team and as such asked @SimonLab to talk through dwylbot with @Cleop this afternoon.
Might be a good exercise for her as she delves into the code?

@Cleop Cleop assigned Cleop and unassigned SimonLab Jun 21, 2017
@Cleop
Copy link
Member

Cleop commented Jun 21, 2017

Going to base a lot of this on: #5

@SimonLab
Copy link
Member Author

It might be good to double check with the actions defined for each rules in the code too

@Cleop
Copy link
Member

Cleop commented Jun 21, 2017

@SimonLab - although I imagine some of the actions aren't yet in the code, even though they will be once the project is finished. Shall I base the list I'm currently writing on what has been done so far or what we would like to be done once the project is complete?

@ghost
Copy link

ghost commented Jun 21, 2017

@Cleop the rules have adapted since that issue so the source of truth is the code. Not all of those rules will necessarily make it in - it's best to base a readme off what's been written into the project (what's been done so far). If you wish you can add a separate section for "Upcoming features" that may change

@SimonLab
Copy link
Member Author

I think on what has been done so far. Then on the next PRs for new rules we need to add the description on the readme, I should have done that from the start. I think there are in some cases some more or different actions implement ed that are not in the epic issue

@Cleop
Copy link
Member

Cleop commented Jun 21, 2017

Great. @SimonLab @markwilliamfirth - how would you feel if I recorded these rules etc in a table format? I think it might be the easiest way to visibly read this content. Happy to move away from this if it doesn't prove effective but thought it might be worth pursuing as a starting point?

@ghost
Copy link

ghost commented Jun 21, 2017

@Cleop table sounds like a nice idea - go with whatever format you think is best at communicating the project to the user 👍

@Cleop
Copy link
Member

Cleop commented Jun 21, 2017

Awesome. Would you like the write up for the 'comment' that the dwylbot leaves to be verbatim or a summary?
This is using a screenshot of the comment dwylbot leaves however it's pretty small because of the width of the table and resizing the image doesn't change that because of the table dimensions.

Category Rule dwylbot comments Labels changed
Pull Requests
ISSUES
Issues Must have a description image -

OR OPTION 2- copied text but no formatting of new lines etc.

Category Rule dwylbot comments Labels changed
Pull Requests
ISSUES
Issues Must have a description #76 ⚠️ @Cleop, this issue has no description. Please add a description to help others understand the context of this issue. -

Without the text after '--' I prefer option 2 because now it's a good size but also readable.

@ghost
Copy link

ghost commented Jun 21, 2017

@Cleop happy for you to decide - verbatim might be a good idea as this will allow us to easily review the comments and know if the wording needs to be updated. The wording/user exerience for each comment hasn't properly been reviewed yet as it's not a priority at the moment. You can omit everything under the -- if you want as it's the same on every comment (maybe have a different section for comment footer?) - whatever you think works best!

Cleop added a commit that referenced this issue Jun 21, 2017
@Cleop Cleop mentioned this issue Jun 21, 2017
@SimonLab SimonLab assigned ghost and unassigned Cleop Jun 26, 2017
@ghost ghost modified the milestone: Backlog Aug 9, 2017
@ghost
Copy link

ghost commented Aug 9, 2017

Closing as this was merged

@ghost ghost closed this as completed Aug 9, 2017
@jammur jammur unassigned ghost Dec 14, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants