Feature: automatic awaiting review label upon reviewer added to PR

[ghost]

When a PR is assigned to someone then add "awaiting-review" label on the PR and on the issues listed in the description of the PR

[changed to when a reviewer is added to a PR]

[SimonLab]

Instead of using the "assignee" property I think we should use the "reviewer" property. I sometimes assign my PR to myself when I need to update it or when it's still in progress.
Otherwise to resolve this issue:

• configure dwylbot app on Github to send event when a PR produce event
• catch the PR events and check for errors (similar to the issues logic)

[ghost]

@SimonLab sounds good 👍

[SimonLab]

I'm wondering now if this rule is still needed, I don't know if it will be applied often, let's test it.
So if a reviewer is added to the PR the "awaiting-label" is added and the reviewer is added as an assignee of the PR.
Adding "awaiting-review" to the issues linked in the PR required more work and might be better done in it's on issue

[Cleop]

@SimonLab - I'm just adding this one to the table of rules, is there meant to be a dwylbot comment with this one to let you know that the awaiting-review label and reviewer have been assigned?

Also, what happens if a reviewer (who has also been assigned) removes the "awaiting-review" label and puts on the "in-review" label. Will dwylbot add the "awaiting-review" label again?

[SimonLab]

@Cleop At the moment I decided to not add a dwylbot comment I thought it will be to noisy on the PR.

[Cleop]

Worked in testing for assigning you when I'd made you a reviewer. Interestingly, it added the 'awaiting-review' label even though I had done so the minute before... this didn't break anything though.

I'll leave this for @markwilliamfirth to test properly as he's been assigned but you can check out this screenshot in case its of interest.

[SimonLab]

@Cleop thanks for testing 👍. Maybe dwylbot could test if the "awainting-review" has been added, not a blocker at the moment. I'm still not sure about this rule I'm creating a new issue to discuss it see #116 .

[ghost]

Tested by Cleo 👍

[SimonLab]

From @markwilliamfirth on this comment (#129 (comment)):

Change message to:
@username, the in-progress label has been removed from this pull request and a Reviewer has been added. It appears that this pull request is ready for review, so the Reviewer has been added as an Assignee and the awaiting-review label has been applied automatically.

[ghost]

@SimonLab I was reminded by this: dwyl/bestevidence#40 (comment)

Can we update the comment to this?

[ghost]

@naazy good point:

@username, hoorah! 🎉 It's review time! 👀

I couldn't help but notice that there isn't an in-progress label on this pull request and a Reviewer has been added...makes me think that this pull request is ready for review 🤔

To save you time ⏳ I've added the Reviewer as an Assignee and I've added the awaiting-review label - automatically - just like magic! 🎩 🐰 ✨ . Please correct me if I'm wrong, but if I got it right this time I hope it helps you! 😄

[ghost]

Linked to #105 (comment)

[ghost]

@naazy still appears to post old message #146 (comment)

Does the app need to be redeployed before testing can occur?

[naazy]

Sorry @markwilliamfirth I thought we had automatic deployment setup. Have spoken to @SimonLab who said he will deploy this evening

[naazy]

Ready to test again @markwilliamfirth 🎉

[ghost]

This works! Nice one @naazy and @SimonLab 🎉

dwyl/dwylbot-test#4 (comment)