Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify lib/options.js using url.parse ? #83

Closed
nelsonic opened this issue May 6, 2015 · 0 comments
Closed

Simplify lib/options.js using url.parse ? #83

nelsonic opened this issue May 6, 2015 · 0 comments

Comments

@nelsonic
Copy link
Member

nelsonic commented May 6, 2015

Can we simplify the parsing of Bonsai/SearchBox urls in lib/options.js:
https://github.com/nelsonic/esta/blob/master/lib/options.js#L17-L27
By using url.parse (node.js core method): https://nodejs.org/docs/latest/api/url.html#url_url_parse_urlstr_parsequerystring_slashesdenotehost
example:
https://github.com/ideaq/hapi-auth-jwt2/blob/master/example/real_world_example_using_redis_on_heroku.js#L10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant