adds tests for util.ex #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
nelsonic
approved these changes
Dec 12, 2018
There was a problem hiding this comment.
@RobStallion this is looking good, but did you mean to open this PR into the dwyl/master or into the origin/master?
|
@nelsonic I didn't really make it clear at all what my plan was with this pr (I didn't add labels or assign anyone 👎). I wanted to get your thoughts on it before a created a pr into I have created the pr now multiformats#9 |
|
@RobStallion these two additions are exactly what we need to PR into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to dwyl/cid#8