Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Increasing code coverage. #11

Merged
merged 4 commits into from
Oct 16, 2023
Merged

[PR] Increasing code coverage. #11

merged 4 commits into from
Oct 16, 2023

Conversation

LuchoTurtle
Copy link
Member

closes #10

Increases code coverage on emoji and image file picking by overriding these systems in widget tests.

@LuchoTurtle LuchoTurtle added documentation Improvements or additions to documentation flutter Flutter related issues in-progress An issue or pull request that is being worked on by the assigned person labels Oct 10, 2023
@LuchoTurtle LuchoTurtle self-assigned this Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #11 (89696dd) into main (9be0f16) will increase coverage by 3.40%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   67.04%   70.45%   +3.40%     
==========================================
  Files           5        5              
  Lines         176      176              
==========================================
+ Hits          118      124       +6     
+ Misses         58       52       -6     
Files Coverage Δ
lib/emoji_picker_widget.dart 100.00% <ø> (+27.77%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LuchoTurtle LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Oct 16, 2023
@LuchoTurtle LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Oct 16, 2023
@LuchoTurtle
Copy link
Member Author

This can now be merged. It paves the way for #12 to also be merged, which also increases code coverage.

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuchoTurtle looks good. Thanks.

@nelsonic nelsonic merged commit a1c14b6 into main Oct 16, 2023
3 checks passed
@nelsonic nelsonic deleted the coverage branch October 16, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed documentation Improvements or additions to documentation flutter Flutter related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Increase code coverage
2 participants