Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR] Addressing edge cases #86

Merged
merged 29 commits into from
Jul 17, 2023
Merged

[PR] Addressing edge cases #86

merged 29 commits into from
Jul 17, 2023

Commits on Jun 27, 2023

  1. fix: Pattern matching when file is read. #69

    @LuchoTurtle
    LuchoTurtle committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    3fa6ba3 View commit details
    Browse the repository at this point in the history

  2. fix: Pattern matching to cover edge cases. #69

    @LuchoTurtle
    LuchoTurtle committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    6dc3b4a View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. feat: Adding tests to check for CID and extension pattern matching. #69

    @LuchoTurtle
    LuchoTurtle committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    1490d08 View commit details
    Browse the repository at this point in the history

  2. fix: Finishing tests. #69

    @LuchoTurtle
    LuchoTurtle committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    317f1be View commit details
    Browse the repository at this point in the history

  3. feat: Adding section to README. #69

    @LuchoTurtle
    LuchoTurtle committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    02933e6 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Chore: rename AWS_S3_BUCKET environment varialble names see: #86 (com… 

    …ment) ref: #80 / #69
    @nelsonic
    nelsonic committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    357c277 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. add *real* test for uploading a JPEG image to S3 #91

    @nelsonic
    nelsonic committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    cc0e976 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. add fail.jpg (deliberately corrupted JPEG file) to test failure #69 / #… 

    …86
    @nelsonic
    nelsonic committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    cb0a9a3 View commit details
    Browse the repository at this point in the history

  2. chore: Refactoring CID and file extension upload part. #69

    @LuchoTurtle
    LuchoTurtle committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    beb03a1 View commit details
    Browse the repository at this point in the history

  3. fix: Refactoring pattern matches on CID and extension.

    @LuchoTurtle
    LuchoTurtle committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    e307c4d View commit details
    Browse the repository at this point in the history

  4. chore: Refactoring upload file to separate function. #69

    @LuchoTurtle
    LuchoTurtle committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    18af780 View commit details
    Browse the repository at this point in the history

  5. fix: Adding ex_aws config in runtime so it works properly. #69

    @LuchoTurtle
    LuchoTurtle committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    f48f346 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into edge-cases-#69 

    # Conflicts:
#	config/config.exs
#	config/runtime.exs
    @LuchoTurtle
    LuchoTurtle committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    cf07017 View commit details
    Browse the repository at this point in the history

  7. fix: Fixing mix.lock and getting tests to work with properly set newl… 

    …y named bucket env variables. #69
    @LuchoTurtle
    LuchoTurtle committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    99dafd5 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. rename "fail.jpg" to "corrupted.jpg" for clarity #69

    @nelsonic
    nelsonic committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    6513f10 View commit details
    Browse the repository at this point in the history

  2. test for empty.jpg - empty file that has a .jpg extension. #69

    @nelsonic
    nelsonic committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c84c857 View commit details
    Browse the repository at this point in the history

  3. add ginger.pdf (valid file) for API test #69

    @nelsonic
    nelsonic committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    84e5593 View commit details
    Browse the repository at this point in the history

  4. update codecov badge in README.md #69

    @nelsonic
    nelsonic committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    4f97807 View commit details
    Browse the repository at this point in the history

  5. fix: Removing mocks and adding rest of edge cases with empty files. #69

    @LuchoTurtle
    LuchoTurtle committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    d43169a View commit details
    Browse the repository at this point in the history

  6. fix: Updating README. #69

    @LuchoTurtle
    LuchoTurtle committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    b4ffe49 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. fix merge conflicts in test/app_web/api_test.exs

    @nelsonic
    nelsonic committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    e75c283 View commit details
    Browse the repository at this point in the history

  2. fix failing test in test/app/upload_test.exs

    @nelsonic
    nelsonic committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    20b7205 View commit details
    Browse the repository at this point in the history

  3. remove stray char from test/app/upload_test.exs (syntax error)

    @nelsonic
    nelsonic committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    2e29f84 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. log the error when upload_file_to_s3/3 fails #69

    @nelsonic
    nelsonic committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    831d2eb View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. comment out out Mock for S3 Upload (false positive) https://github.co… 

    …m/dwyl/imgup/pull/86/files#r1264339056
    @nelsonic
    nelsonic committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    ef113ec View commit details
    Browse the repository at this point in the history

  2. fix: Logging errors and returning relevant information to the person … 

    …only.
    @LuchoTurtle
    LuchoTurtle committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    4c4a1a5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'edge-cases-#69' of https://github.com/dwyl/imgup into e… 

    …dge-cases-#69

# Conflicts:
#	lib/app_web/controllers/api_controller.ex
#	test/app_web/api_test.exs
    @LuchoTurtle
    LuchoTurtle committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    37d073c View commit details
    Browse the repository at this point in the history

  4. chore: Updating API.md document with latest changes. #69

    @LuchoTurtle
    LuchoTurtle committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    ab7fda5 View commit details
    Browse the repository at this point in the history

  5. feat: Add API return error when content type is invalid. #69

    @LuchoTurtle
    LuchoTurtle committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    40e5455 View commit details
    Browse the repository at this point in the history