Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Update to GitHub Workflow + Badges #35

Merged
merged 6 commits into from
Nov 3, 2021
Merged

PR: Update to GitHub Workflow + Badges #35

merged 6 commits into from
Nov 3, 2021

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Nov 3, 2021 •
edited
Loading

  • add GitHub workflow for Tidy up Badges #34
  • update CI/build badge
  • update Hits badge to use .com

@nelsonic
Copy link
Member Author

nelsonic commented Nov 3, 2021

Annoyingly, for Node.js projects, we are forced to upload the package-lock.json file (super noisy) to GitHub:
https://github.com/dwyl/javascript-todo-list-tutorial/runs/4094346133?check_suite_focus=true#step:3:11
image

@nelsonic
Copy link
Member Author

nelsonic commented Nov 3, 2021

Done. ✅
GitHub Workflow Status
codecov.io
Dependencies: None
contributions welcome
HitCount

@nelsonic nelsonic mentioned this pull request Nov 3, 2021
Closed
6 tasks
@nelsonic
Copy link
Member Author

nelsonic commented Nov 3, 2021

@SimonLab hopefully this update is self-explanatory. Thanks for review+merge. 👍

@nelsonic nelsonic mentioned this pull request Nov 3, 2021
Open
1 task
SimonLab
SimonLab approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@SimonLab SimonLab merged commit aae70c8 into master Nov 3, 2021
@SimonLab SimonLab deleted the tidy-badges-issue-#34 branch November 3, 2021 16:18
@nelsonic nelsonic mentioned this pull request Nov 3, 2021
Closed
6 tasks
@nelsonic nelsonic changed the title Update to GitHub Workflow + Badges PR: Update to GitHub Workflow + Badges Nov 16, 2022
@nelsonic nelsonic mentioned this pull request Nov 16, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonLab SimonLab SimonLab approved these changes

Assignees

@SimonLab SimonLab

Labels
awaiting-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @SimonLab