Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Label Descriptions issue #84 #93

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Add Label Descriptions issue #84 #93

merged 2 commits into from
Jul 31, 2020

Conversation

nelsonic
Copy link
Member

This pull request adds the code to sync label descriptions as described in #84 :shipit:
Unfortunately, a couple of the tests fail as noted in #92 😞 (due to a breaking change in dependency...)

The only way we can fix the failing tests is to manually debug each one ... ⏳
https://travis-ci.org/github/dwyl/labels/builds/713637356#L552

The application works flawlessly on my localhost:
label-sync-success-localhost

https://github.com/nelsonic/learn-music/labels

Before:
nelsonic-learn-music-before-sync

After:
nelsonic-learn-music-after-sync-with-label-descriptions

@nelsonic nelsonic added the awaiting-review An issue or pull request that needs to be reviewed label Jul 31, 2020
@nelsonic nelsonic requested a review from iteles July 31, 2020 10:33
@nelsonic nelsonic mentioned this pull request Jul 31, 2020
Closed
@iteles iteles added in-review Issue or pull request that is currently being reviewed by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Jul 31, 2020
iteles
iteles approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nelsonic!

I'm merging now as the tests that Travis CI is grumbling about are captured in #92

@iteles iteles merged commit 0191571 into master Jul 31, 2020
@iteles iteles deleted the add-label-descriptions-issue-84 branch July 31, 2020 10:47
@nelsonic
Copy link
Member Author

@iteles thanks. We will need to address the failing tests at some point ... ⏳
As noted in #92 I'd honestly prefer to migrate the whole thing to Phoenix as another useful showcase App.
But it's definitely nowhere near the top of my priority list.

@nelsonic nelsonic mentioned this pull request Aug 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iteles iteles iteles approved these changes

Assignees

@iteles iteles

Labels
in-review Issue or pull request that is currently being reviewed by the assigned person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @iteles