Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding part of the summary from Effective Dart #12

Merged
merged 8 commits into from
Feb 19, 2020

Conversation

miguelmartins17
Copy link
Collaborator

Adding the Effective Code in Flutter and Dartanalyzer

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miguelmartins17 please see my comments/suggestions. 👍
Summarising knowledge is a skill you want to keep practicing. ✍️
You don't want the person reviewing your summary to have to go and re-read the source material to confirm that it's correct. 💭

miguelmartins17 and others added 2 commits February 17, 2020 19:25
Co-Authored-By: Nelson <nelson+github@dwyl.io>
@nelsonic
Copy link
Member

nelsonic commented Feb 18, 2020

@miguelmartins17 please fix merge-conflicts in README.md then re-assign for merge. Thanks. ☀️
see: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-merge-conflicts

README.md Outdated Show resolved Hide resolved
Co-Authored-By: Nelson <nelson+github@dwyl.io>
README.md Show resolved Hide resolved
Co-Authored-By: Nelson <nelson+github@dwyl.io>
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miguelmartins17 looks good. thanks! 👍

@nelsonic nelsonic merged commit efc2315 into dwyl:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants