-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding information about Flutter and the utility #24
Conversation
README.md
Outdated
|
||
![Screen Shot 2020-02-06 at 19 01 17](https://user-images.githubusercontent.com/27420533/73969408-4475d280-4913-11ea-8384-99c863321155.png) | ||
|
||
Widgets are themselves often composed of many small, single-purpose widgets that combine to produce powerful effects.</br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miguelmartins17 please do not copy-paste directly from the Flutter docs.
google search
What you have added here is identical to the Flutter Technical overview
https://flutter.dev/docs/resources/technical-overview
Maybe your teachers did not care about students copy-pasting large blocks of text but we do.
- it does not show that you have learned/understood the concepts; it just shows you are being lazy.
- You should be learning how to synthesize (or "summarise" if you prefer) other people's writing.
- https://en.wikipedia.org/wiki/Plagiarism
Please re-write this in your own words or simply link to the official docs given that they include images and have been written by professional technical writers.
@nelsonic When you have time please if you can review this 👍 |
@miguelmartins17 when you feel you have finished working on the PR, please assign it to me and update the label from |
@miguelmartins17 the PR is still assigned to you ... The reason we update the assignee is so that it's clear who's "turn" it is. |
To be clear: the reason I left a comment on the PR yesterday |
@nelsonic So is it necessary to change the Assignees for you ? 😕 |
Miguel, if you it's too much effort for you to follow a systematic approach, please let me know. 👍 |
@nelsonic Of course, I didn't even say anything like that, I just didn't understand if you're supposed to be Assignee. |
@nelsonic In case you didn't realize my approach was in a tone of doubt not in a tone of thinking it is a strange method. |
Miguel, what you're saying is that you didn't read the instructions or link I shared above. #24 (comment) ⬆️ Reading the contributing guide is a requirement ... https://github.com/dwyl/apprenticeship#prerequisites I'm not trying to be difficult, I just want you to understand that every company/organisation has a "workflow" for getting work done. Most software companies are a lot more tedious than ours. 👍 |
@nelsonic I read it now and I understand what you mean. Obviously I wasn't going to merge the text I was trying to add without someone doing the review first, I already had wrong before. |
- Flutter can be used to build applications for Android and IOS | ||
- The Dart language used in Flutter is quite similar to Java | ||
- We can update the application in real time | ||
- If we close the application when we open it again we can continue from where we were |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This benefit is not exclusive to Flutter development and it's unclear what this means.
Are you saying that you can pickup your work in the IDE or When you re-open the test app on the device?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was talking about getting us back to where we were at the IDE.
But it probably wasn't the best advantage of using Flutter.
There is also the "Hot reload" advantage that allows the developer to see changes made only to what was modified without having to run the application from the beginning again.
Flutter reloads only the screen that was changed and faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All modern IDEs have this feature so that people don't lose their work when the IDE or OS crashes.
Try opening a Phoenix project in Atom. Open a bunch of files in several tabs.
Quit the Atom and re-open it. You'll see that the active tab will still be active when you re-open the app.
Hot reloading is a major benefit of Dart/Flutter. 👍
Widgets form a hierarchy whenever we use one of them we will have another that will complement it.</br> | ||
There are widgets that are used in all applications and some that are used in specific situations.</br> | ||
|
||
![Screen Shot 2020-02-06 at 19 01 17](https://user-images.githubusercontent.com/27420533/73969408-4475d280-4913-11ea-8384-99c863321155.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good image showing the hierarchy of widgets. Did you create the diagram?
If you didn't create it from scratch, please attribute it to the source where you got it.
e.g: this gif explains the Flutter widget hierarchy visually:
See: https://dev.to/rubensdemelo/flutter-widget-tree-and-state-management-31an
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow is a really good and different illustration of how Flutter works.
Super interesting a diagram like this. 🆒 😃
The Flutter is formed by several layers that are each layer and built one on top of the other. | ||
|
||
|
||
![Screen Shot 2020-02-07 at 09 06 06](https://user-images.githubusercontent.com/27420533/74015797-36629900-4989-11ea-8ec1-757aecad18ce.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another good image, but it looks familiar ... https://www.zup.com.br/blog/flutter
Please attribute the source of images when you "borrow" them from someone else
's blog post. 💭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miguelmartins17 this is a good addition. 👍
I have made a few suggestions. The review process is meant to be a learning experience.
Please read through my comments & suggestions and reply to them.
Click the "Add suggestion to batch":
Once you've added all the suggestions, you can commit them to the branch.
Once you have finished replying to my comments/suggestions,
please (re)assign the PR back to me for final review & merge.
Thanks. 👍
@nelsonic Where should I click now ? |
Co-Authored-By: Nelson <contact.nelsonic+github@gmail.com>
@miguelmartins17 what are the options when you click on "Review changes"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miguelmartins17 thanks for replying to my review comments and accepting my suggestions. 👍
I've added some topics like why you should use/learn Flutter , the core principles and how widgets work.
I hope it helps and that it can improve the repository. 👍