Remove people table completely? ✂️

[nelsonic]

@SimonLab made a very valid/insightful point in #115 (comment) ... 💭
At present the people table is simply mirroring the contents of people from auth
via the JWT when the person successfully authenticates ...
i.e. we are storing the data in the MVP App and don't actually need to.

Two Questions:

1. Will it be confusing to a complete beginner to
not have the people table in the MVP?

At present we have the following ERD as part of the update: #89 (comment)

To me this makes it reasonably clear what the link between the tables is.
But if we were to remove people, would it still be clear that an item "belongs" to a person?

Removing the people table will not alter the functionality of the MVP ... 📱 📝 ⏳ ✅
But it will result in less code & tests. 🎉
So I'm very much considering it. 💭

2. Will we have a people table in the "real" App?

Once we have finished testing the MVP and we port the code over to the "real" App,
do we want to have a people table? or can we exclude it completely and have a separation of concerns?
i.e. only have the items.person_id reference and store all personal data encrypted in the auth App?

[nelsonic]

Given that the goal of this repo/project is the minimum code, I'm leaning toward removing the table/schema. 💭

[SimonLab]

My preference would also be to remove the people table for now. Like you said, less code is good!
I don't think it would be to time consuming to add back a table if we need it later on, at the moment auth provides all the info necessary for the MVP to work.

[nelsonic]

@SimonLab thank you for suggesting the removal. 👌
I'm happy to get it done now as part of my README.md update ... 👨‍💻
The good news is we can just delete it from the Fly App without any consequences. (once the foreign keys are removed)
But I totally agree I think the MVP will be substantially simplified by removing it!

[nelsonic]

Successfully removes people schema/table from the project: 316929c ✂️

New ERD:

It's almost comically simple compared to the previous version of the MVP: #89 (comment)

Everything still works as expected. 📝 ⏳ ✅
Thanks again for the suggestion. 👌

[SimonLab]

I haven't looked in details at the commit to remove the people table yet, but I'm thinking that if the person_id defined on the items can be null, I think we can also remove the seeds data used to describe guest users: If the person_id is not null is is linked to a loggedin user, otherwise if null it is a public item and created linked to "guest".

Just saw you already removed the seeds: https://github.com/dwyl/app-mvp/blob/phoenix-1.6-2022-refresh-issue-%2389/priv/repo/seeds.exs 👍

[nelsonic]

Having to remove people table again is a huuuuge waste of time.
This decision was made. We didn't need to re-add this table. 😢