Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON Lint quotes.json during CI to avoid breaking the file! #3

Closed
1 task done
nelsonic opened this issue Oct 12, 2019 · 3 comments
Closed
1 task done

JSON Lint quotes.json during CI to avoid breaking the file! #3

nelsonic opened this issue Oct 12, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@nelsonic
Copy link
Member

nelsonic commented Oct 12, 2019 •
edited
Loading

I made several manual changes to quotes.json and broke it. 😞

Thankfully, I've done a ton of work with JSON in the past so I knew to use https://jsonlint.com to debug:
image

Todo
@nelsonic nelsonic added the enhancement New feature or request label Oct 12, 2019
@nelsonic
Copy link
Member Author

nelsonic commented Oct 12, 2019 •
edited
Loading

Multiple Languages in the same .travis.yml file:
https://stackoverflow.com/questions/27644586/how-to-set-up-travis-ci-with-multiple-languages

nelsonic added a commit that referenced this issue Oct 14, 2019
@nelsonic
add :excoveralls to mix.exs to to check coverage on CI #3
72c7daf
nelsonic added a commit that referenced this issue Oct 15, 2019
@nelsonic
add node_modules to .gitignore #3
15212d2
nelsonic added a commit that referenced this issue Oct 15, 2019
@nelsonic
create .travis.yml for #3
2852b2f
nelsonic added a commit that referenced this issue Oct 15, 2019
@nelsonic
create package.json so we can run jsonlint on Travis-CI #3
e377226
@nelsonic
Copy link
Member Author

I deliberately removed a comma from quotes.json and ran validate command:
image

Validation works. 👍

nelsonic added a commit that referenced this issue Oct 15, 2019
@nelsonic
update version of elixir to 1.9 #3
cff0256
@nelsonic
Copy link
Member Author

This is working. see: https://travis-ci.org/dwyl/quotes/builds/598064475#L197 ✅

nelsonic added a commit that referenced this issue Oct 15, 2019
@nelsonic
add jsonlint script to package.json and "npm run jsonlint" in .travis…
71fdb47 
….ci for #3
nelsonic added a commit that referenced this issue Oct 29, 2019
@nelsonic
Yay! The jsonlint on Travis CI #3 works! 🎉 (my JSON failure was caugh…
ec70de5 
…t!) 🙄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic