Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: adds section headings for linking to terms #42 #43

Merged
merged 6 commits into from
Jun 20, 2022
Merged

PR: adds section headings for linking to terms #42 #43

merged 6 commits into from
Jun 20, 2022

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Jun 17, 2022 •
edited
Loading

@nelsonic nelsonic added enhancement New feature or request chore in-progress labels Jun 17, 2022
@nelsonic nelsonic mentioned this pull request Jun 17, 2022
Closed
4 tasks
@nelsonic nelsonic changed the title [WiP] PR: adds section headings for linking to terms #42 PR: adds section headings for linking to terms #42 Jun 17, 2022
@nelsonic
Copy link
Member Author

@SimonLab please take a look when you have 10 mins spare to read through. Not urgent. Thanks.

@nelsonic nelsonic assigned nelsonic and SimonLab and unassigned nelsonic Jun 17, 2022
@nelsonic nelsonic requested a review from SimonLab June 17, 2022 11:52
SimonLab
SimonLab reviewed Jun 17, 2022
View reviewed changes
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why these two sections (CSS box model, and CRUD) aren't display properly:
image

https://github.com/dwyl/technical-glossary/blob/c3ae752c7f1484055dc4a55859595f64c910586f/README.md

@nelsonic do you have an ideas what is the issue here?

@nelsonic
Copy link
Member Author

Markdown fail. Will fix when I’m back at my desk. 👌🏻

@nelsonic
Copy link
Member Author

@SimonLab https://github.com/dwyl/technical-glossary/blob/11bd1006d6d21e7463c54ad4c3d1a3c78cd87694/README.md#css-box-model

image

Thanks. 👍

SimonLab
SimonLab reviewed Jun 17, 2022
View reviewed changes
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the markdown @nelsonic, just spotted a few typos

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@nelsonic nelsonic mentioned this pull request Jun 18, 2022
Open
1 task
@nelsonic @SimonLab
Apply suggestions [typo fixes] from code review #43
986c487 
Co-authored-by: Simon <simon@dwyl.com>
@nelsonic
Copy link
Member Author

@SimonLab thanks for fixing the typos. 👍
Really need a long-term solution for this. dwyl/dev-setup#45 ...

Hope you have a great day. ☀️

SimonLab
SimonLab approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links up to date, thanks!

@SimonLab SimonLab merged commit 677e6a1 into main Jun 20, 2022
@SimonLab SimonLab deleted the section-headers-for-linking-issue-#42 branch June 20, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonLab SimonLab SimonLab approved these changes

Assignees

@SimonLab SimonLab

Labels
awaiting-review chore enhancement New feature or request priority-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @SimonLab