use process.kill instead of spawning linux kill #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #20 diff @@
===================================
Files 1 1
Lines 10 13 +3
Methods 0 0
Messages 0 0
Branches 0 0
===================================
+ Hits 10 13 +3
Misses 0 0
Partials 0 0
|
This was referenced Oct 27, 2016
Merged
Merged
nelsonic
reviewed
Oct 27, 2016
| try { | ||
| process.kill(pid, 'SIGKILL'); | ||
| } catch (error) { | ||
| // ignore |
There was a problem hiding this comment.
we are unlikely to get test coverage on this line ... we may need to /* istanbul ignore */ it ...
|
@jedwards1211 looks good. thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #19