Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Help Wanted' image/ title #171

Closed
2 tasks
Cleop opened this issue Jul 28, 2017 · 3 comments · Fixed by #215
Closed
2 tasks

Add 'Help Wanted' image/ title #171

Cleop opened this issue Jul 28, 2017 · 3 comments · Fixed by #215
Labels
enhancement priority-2 PT25m
Milestone
Elixir MVP

Comments

@Cleop
Copy link
Member

Cleop commented Jul 28, 2017 •
edited
Loading

  • Source image as per @harrygfox 's suggestion saying 'help wanted' like a shop window
  • Style the image to fit/ position top left on desktop and mobile

Potential images:

From: http://www.msnbc.com/sites/msnbc/files/styles/ratio--3-2--830x553/public/articles/163366209.jpg?itok=52xYDIsu

From: https://www.google.pt/url?sa=i&rct=j&q=&esrc=s&source=images&cd=&ved=0ahUKEwis9JH_q6zVAhUDbxQKHThqCFQQjRwIBw&url=http%3A%2F%2Fwww.thestorestarters.com%2F3-reasons-put-help-wanted-sign-new-stores-window%2F&psig=AFQjCNGProvS4mjBLqYUapnCdizMZgCHKQ&ust=1501343761242817

From: https://www.google.pt/url?sa=i&rct=j&q=&esrc=s&source=images&cd=&ved=0ahUKEwjA4taKrKzVAhUBaRQKHa_6BvIQjRwIBw&url=http%3A%2F%2Fwww.newsnky.com%2F&psig=AFQjCNGProvS4mjBLqYUapnCdizMZgCHKQ&ust=1501343761242817
@Cleop Cleop added this to the Elixir MVP milestone Jul 28, 2017
@Cleop Cleop mentioned this issue Jul 28, 2017
Closed
4 tasks
@samhstn samhstn mentioned this issue Jul 28, 2017
Closed
8 tasks
@harrygfox
Copy link
Member

@Cleop I just slapped this together - I've used the green colour of the help wanted label
sign

Let me know if you think a different colour or anything should be different!
Also, I can send over an .svg file too if you like.

@nelsonic
Copy link
Member

nelsonic commented Aug 1, 2017

image

Jbarget added a commit that referenced this issue Aug 13, 2017
@Jbarget
Adds styling #172 #204 #171 #177
8590443 
- adds logic for rendering css components
- creates issue_card component
- extracts label rendering into label component
- adjusts header for mobile first styles
Jbarget added a commit that referenced this issue Aug 13, 2017
@Jbarget
Adds styling #172 #204 #171 #177
5d98a61 
- adds logic for rendering css components
- creates issue_card component
- extracts label rendering into label component
- adjusts header for mobile first styles
@Jbarget
Copy link
Member

Jbarget commented Aug 18, 2017

ah whoops i didn't see the above from Harry, this is still outstanding in that case

FYI At the moment the title is just the text "Help Wanted"
https://github.com/dwyl/tudo/blob/master/web/templates/page/index.html.eex#L2

Jbarget added a commit that referenced this issue Aug 18, 2017
@Jbarget
adding help-wanted image for title instead of text #171
aab720f
@Jbarget Jbarget mentioned this issue Aug 18, 2017
Merged
samhstn pushed a commit that referenced this issue Aug 18, 2017
@Shouston3
Merge pull request #215 from dwyl/help-wanted-image
172d73e 
adding help-wanted image for title instead of text #171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement priority-2 PT25m
Projects
None yet
Milestone
Elixir MVP
Development

Successfully merging a pull request may close this issue.

adding help-wanted image for title instead of text #171 dwyl/tudo
4 participants
@nelsonic @harrygfox @Jbarget @Cleop