Skip to content

Conversation

iamishalkin
Copy link
Member

listeners have all fields defined in c header files
one more example with all types of subscription added

@iamishalkin iamishalkin added the enhancement New feature or request label Jun 19, 2020
@iamishalkin iamishalkin requested a review from asalynskii June 19, 2020 14:26
Copy link
Contributor

@asalynskii asalynskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is list to consider:

  • TimeNanos vs Nanos
  • Reorder columns in listeners according to the used structures
  • Replace * in imports with namespace usage

@iamishalkin iamishalkin requested a review from asalynskii July 30, 2020 08:10
@iamishalkin iamishalkin requested a review from asalynskii July 30, 2020 13:44
@asalynskii asalynskii merged commit 190ec83 into master Jul 30, 2020
@asalynskii asalynskii deleted the EN-1454-extend-listeners branch October 7, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants