En 1335 correct samples and doc #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be better to replace usage of stand-alone file with call to PyPI here -> |
asalynskii
requested changes
Apr 21, 2020
pyproject.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [tool.poetry] | |||
| name = "dxfeed" | |||
| version = "0.1.0" | |||
| version = "0.1.1" | |||
| description = "DXFeed Python API via C API" | |||
| authors = ["Ivan Mishalkin <ivan.mishalkin@devexperts.com>", | |||
There was a problem hiding this comment.
Please change order so ppl will drop messages to im@dxfeed.com
asalynskii
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs and jupyter notebook edited for fixing antipattern