Skip to content
This repository was archived by the owner on Mar 18, 2024. It is now read-only.

fix(picklist): fix org response and exclude custom metadata picklists #1336

Merged
merged 1 commit into from
Jun 28, 2023
Merged

fix(picklist): fix org response and exclude custom metadata picklists #1336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/core/src/package/deploymentCustomizers/PicklistEnabler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ export default class PicklistEnabler implements DeploymentCustomizer {
if (!customField || customField['type'] !== 'Picklist' || !customField.valueSet?.valueSetDefinition) {
continue;
}
//no updates for custom metadata picklists
if(customField['fieldManageability']) continue;

let objName = fieldComponent.parent.fullName;
let picklistName = fieldComponent.name;
Expand All @@ -78,7 +80,7 @@ export default class PicklistEnabler implements DeploymentCustomizer {

for (const value of picklistInOrg.Metadata.valueSet.valueSetDefinition.value) {

if (value.isActive == false) {
if (value.isActive == 'false') {
continue;
}

Expand Down Expand Up @@ -115,7 +117,7 @@ export default class PicklistEnabler implements DeploymentCustomizer {

let response = await QueryHelper.query<any>(urlId, conn, true);

if (response) {
if (response && Array.isArray(response) && response.length > 0 && response[0].attributes) {
let responseUrl = response[0].attributes.url;
let fieldId = responseUrl.slice(responseUrl.lastIndexOf('.') + 1);
let responsePicklist = await conn.tooling.sobject('CustomField').find({ Id: fieldId });
Expand Down