Skip to content

[Patch] Fix #355 Accordion assistive text #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2021
Merged

[Patch] Fix #355 Accordion assistive text #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/dxc-ngx-cdk-examples/src/app/pages/accordion/accordion.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div>
<div style="width: 1000px;">
<div className="test-case" id="uncontrolled">
<h4>Uncontrolled Accordion</h4>
<dxc-accordion
Expand Down
17 changes: 14 additions & 3 deletions projects/dxc-ngx-cdk/src/lib/dxc-accordion/dxc-accordion.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ import {
import { CssUtils } from "../utils";
import { BehaviorSubject } from "rxjs";
import { css } from "emotion";
import { coerceBooleanProperty, coerceNumberProperty } from '@angular/cdk/coercion';
import {
coerceBooleanProperty,
coerceNumberProperty,
} from "@angular/cdk/coercion";
import { DxcAccordionIconComponent } from "./dxc-accordion-icon/dxc-accordion-icon.component";
import { QueryList, ChangeDetectorRef, ElementRef } from "@angular/core";

Expand Down Expand Up @@ -68,7 +71,7 @@ export class DxcAccordionComponent implements OnInit, OnChanges, AfterViewInit {
margin: null,
padding: null,
disabled: false,
tabIndexValue: 0
tabIndexValue: 0,
});

constructor(
Expand Down Expand Up @@ -135,7 +138,7 @@ export class DxcAccordionComponent implements OnInit, OnChanges, AfterViewInit {
}
}
.mat-expansion-panel:not(.mat-expanded)
.mat-expansion-panel-header:not([aria-disabled="true"]).cdk-keyboard-focused{
.mat-expansion-panel-header:not([aria-disabled="true"]).cdk-keyboard-focused {
background: transparent !important;
}
mat-expansion-panel {
Expand Down Expand Up @@ -186,6 +189,14 @@ export class DxcAccordionComponent implements OnInit, OnChanges, AfterViewInit {
font: italic normal 300 16px/22px var(--fontFamily);
justify-content: flex-end;
margin-right: 24px;
overflow: hidden;
span {
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
text-align: end;
width: 100%;
}
}
}
}
Expand Down