Skip to content

[Minor] Added new prop autocomplete on inputs components #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2022
Merged

[Minor] Added new prop autocomplete on inputs components #616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...ite/src/app/components/examples/date-input/date-properties/date-properties.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,4 +126,15 @@
</td>
<td>Value of the tabindex attribute.</td>
</tr>
<tr>
<td>autocomplete: string</td>
<td><code>'off'</code></td>
<td>
HTML autocomplete attribute. Lets the user specify if any permission the
user agent has to provide automated assistance in filling out the input
value. Its value must be one of all the possible values of the HTML
autocomplete attribute: 'on', 'off', 'email', 'username', 'new-password',
...
</td>
</tr>
</dxc-table>
15 changes: 13 additions & 2 deletions ...c/app/components/examples/number-input/number-properties/number-properties.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@
<td>onChange: EventEmitter</td>
<td></td>
<td>
This function will be called when the user types within the number. An object
including the new value and the error will be passed to this
This function will be called when the user types within the number. An
object including the new value and the error will be passed to this
function. An example of this object is:
{{ "{" }}
<code>value: value, error: error</code>
Expand Down Expand Up @@ -132,4 +132,15 @@
</td>
<td>Value of the tabindex attribute.</td>
</tr>
<tr>
<td>autocomplete: string</td>
<td><code>'off'</code></td>
<td>
HTML autocomplete attribute. Lets the user specify if any permission the
user agent has to provide automated assistance in filling out the input
value. Its value must be one of all the possible values of the HTML
autocomplete attribute: 'on', 'off', 'email', 'username', 'new-password',
...
</td>
</tr>
</dxc-table>
29 changes: 20 additions & 9 deletions ...components/examples/password-input/password-properties/password-properties.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
<td>value: string</td>
<td></td>
<td>
Value of the input element. If undefined, the component will be uncontrolled
and the value will be managed internally by the component.
Value of the input element. If undefined, the component will be
uncontrolled and the value will be managed internally by the component.
</td>
</tr>
<tr>
Expand Down Expand Up @@ -56,10 +56,10 @@
<td>onChange: EventEmitter</td>
<td></td>
<td>
This function will be called when the user types within the input
element of the component. An
object including the value and the error (if the value entered is not
valid) will be passed to this function. An example of this object is:
This function will be called when the user types within the input element
of the component. An object including the value and the error (if the
value entered is not valid) will be passed to this function. An example of
this object is:
{{ "{" }} <code>value: value, error: error</code>{{ "}" }}. If there is no
error, error will be null.
</td>
Expand All @@ -68,9 +68,9 @@
<td>onBlur: EventEmitter</td>
<td></td>
<td>
This function will be called when the input element loses the focus. An object
including the value and the error (if the value entered is not valid) will
be passed to this function. An example of this object is:
This function will be called when the input element loses the focus. An
object including the value and the error (if the value entered is not
valid) will be passed to this function. An example of this object is:
{{ "{" }}
<code>value: value, error: error</code>
{{ "}" }}. If there is no error, error will be null.
Expand Down Expand Up @@ -128,4 +128,15 @@
</td>
<td>Value of the tabindex attribute.</td>
</tr>
<tr>
<td>autocomplete: string</td>
<td><code>'off'</code></td>
<td>
HTML autocomplete attribute. Lets the user specify if any permission the
user agent has to provide automated assistance in filling out the input
value. Its value must be one of all the possible values of the HTML
autocomplete attribute: 'on', 'off', 'email', 'username', 'new-password',
...
</td>
</tr>
</dxc-table>
17 changes: 13 additions & 4 deletions ...components/examples/text-input/text-input-properties/text-input-properties.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,17 +51,16 @@
<td></td>
<td>
If it is defined, the component will change its appearance, showing the
error below the input component. If it is not defined, the error messages will be created and managed internally.
error below the input component. If it is not defined, the error messages
will be created and managed internally.
</td>
</tr>
<tr>
<td>clearable: boolean</td>
<td>
<code>false</code>
</td>
<td>
If true, the input will have an action to clear the entered value.
</td>
<td>If true, the input will have an action to clear the entered value.</td>
</tr>
<tr>
<td>optional: boolean</td>
Expand Down Expand Up @@ -120,6 +119,16 @@
will be null.
</td>
</tr>
<tr>
<td>autocomplete: string</td>
<td><code>'off'</code></td>
<td>
HTML autocomplete attribute. Lets the user specify if any permission the
user agent has to provide automated assistance in filling out the input
value. Its value must be one of all the possible values of the HTML
autocomplete attribute. Please check the documentation <dxc-link href="https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete" text="here"></dxc-link>.
</td>
</tr>
<tr>
<td>length: object</td>
<td></td>
Expand Down
15 changes: 13 additions & 2 deletions ...c/app/components/examples/textarea/textarea-properties/textarea-properties.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@
<td>onChange: EventEmitter</td>
<td></td>
<td>
This function will be called when the user types within the textarea. An object
including the new value and the error will be passed to this
This function will be called when the user types within the textarea. An
object including the new value and the error will be passed to this
function. An example of this object is:
{{ "{" }}
<code>value: value, error: error</code>
Expand Down Expand Up @@ -167,4 +167,15 @@
</td>
<td>Value of the tabindex attribute.</td>
</tr>
<tr>
<td>autocomplete: string</td>
<td><code>'off'</code></td>
<td>
HTML autocomplete attribute. Lets the user specify if any permission the
user agent has to provide automated assistance in filling out the textarea
value. Its value must be one of all the possible values of the HTML
autocomplete attribute: 'on', 'off', 'email', 'username', 'new-password',
...
</td>
</tr>
</dxc-table>
1 change: 1 addition & 0 deletions projects/dxc-ngx-cdk/src/lib/dxc-date-input/dxc-date-input.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
[mdePopoverOffsetX]="popOverOffsetX"
[mdePopoverPositionX]="'before'"
[tabIndex]="tabIndex"
[autocomplete]="autocomplete"
>
<dxc-text-input-action>
<svg
Expand Down
3 changes: 3 additions & 0 deletions projects/dxc-ngx-cdk/src/lib/dxc-date-input/dxc-date-input.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ export class DxcDateInputComponent implements OnInit {
@Input()
tabIndex: number;

@Input()
autocomplete: string = "off";

defaultInputs = new BehaviorSubject<any>({
error: "",
clearable: false,
Expand Down
1 change: 1 addition & 0 deletions projects/dxc-ngx-cdk/src/lib/dxc-number-input/dxc-number-input.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
[tabIndex]="tabIndex"
[disabled]="disabled"
[optional]="optional"
[autocomplete]="autocomplete"
>
<ng-content select="dxc-text-input-suffix" ngProjectAs="dxc-text-input-suffix"></ng-content>
<ng-content select="dxc-text-input-prefix" ngProjectAs="dxc-text-input-prefix"></ng-content>
Expand Down
3 changes: 3 additions & 0 deletions projects/dxc-ngx-cdk/src/lib/dxc-number-input/dxc-number-input.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ export class DxcNumberInputComponent implements OnInit, OnChanges, OnDestroy {
@Input()
size: string = "medium";

@Input()
autocomplete: string = "off";

private controlled: boolean;

defaultInputs = new BehaviorSubject<any>({
Expand Down
1 change: 1 addition & 0 deletions projects/dxc-ngx-cdk/src/lib/dxc-password-input/dxc-password-input.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
(onBlur)="handleOnBlur($event)"
(onActionClick)="handleMaskPassword()"
[tabIndex]="tabIndex"
[autocomplete]="autocomplete"
>
<dxc-text-input-action>
<svg
Expand Down
3 changes: 3 additions & 0 deletions projects/dxc-ngx-cdk/src/lib/dxc-password-input/dxc-password-input.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ export class DxcPasswordInputComponent implements OnInit, OnChanges {
@Input()
size: string = "medium";

@Input()
autocomplete: string = "off";

defaultInputs = new BehaviorSubject<any>({
error: "",
helperText: "",
Expand Down
1 change: 1 addition & 0 deletions projects/dxc-ngx-cdk/src/lib/dxc-text-input/dxc-text-input.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
[attr.aria-expanded]="suggestions && autosuggestVisible"
[attr.aria-controls]="suggestions && autoSuggestId"
[attr.aria-autocomplete]="suggestions && 'list'"
[autocomplete]="autocomplete"
/>
<span
*ngIf="error && !disabled"
Expand Down
3 changes: 3 additions & 0 deletions projects/dxc-ngx-cdk/src/lib/dxc-text-input/dxc-text-input.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ export class DxcTextInputComponent
@Input()
helperText: string;

@Input()
autocomplete: string = "off";

hasAction = () => this.onActionClick.observers.length;

@Input()
Expand Down
1 change: 1 addition & 0 deletions projects/dxc-ngx-cdk/src/lib/dxc-textarea/dxc-textarea.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@
type="text"
class="textarea"
(focus)="handleOnFocus()"
[attr.autocomplete]="autocomplete"
></textarea>
<span *ngIf="error && !disabled" class="textareaErrorMessage">{{ error }}</span>
3 changes: 3 additions & 0 deletions projects/dxc-ngx-cdk/src/lib/dxc-textarea/dxc-textarea.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ export class DxcTextareaComponent implements OnInit {
@Input()
size: string;

@Input()
autocomplete: string = "off";

private controlled: boolean;

defaultInputs = new BehaviorSubject<any>({
Expand Down