[OTE-129] remove geoblocking from Indexer endpoints #1029
Conversation
WalkthroughThe recent updates involve the removal of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (9)
- indexer/services/comlink/src/controllers/api/v4/candles-controller.ts (2 hunks)
- indexer/services/comlink/src/controllers/api/v4/compliance-controller.ts (2 hunks)
- indexer/services/comlink/src/controllers/api/v4/height-controller.ts (2 hunks)
- indexer/services/comlink/src/controllers/api/v4/historical-funding-controller.ts (2 hunks)
- indexer/services/comlink/src/controllers/api/v4/orderbook-controller.ts (2 hunks)
- indexer/services/comlink/src/controllers/api/v4/perpetual-markets-controller.ts (2 hunks)
- indexer/services/comlink/src/controllers/api/v4/sparklines-controller.ts (2 hunks)
- indexer/services/comlink/src/controllers/api/v4/time-controller.ts (2 hunks)
- indexer/services/comlink/src/controllers/api/v4/trades-controller.ts (2 hunks)
Files skipped from review due to trivial changes (1)
- indexer/services/comlink/src/controllers/api/v4/historical-funding-controller.ts
Additional comments: 8
indexer/services/comlink/src/controllers/api/v4/time-controller.ts (1)
- 4-9: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
The removal of
rejectRestrictedCountriesmiddleware is aligned with the PR's objective to disable geoblocking. Ensure that all necessary updates to documentation and tests reflecting this change are made.indexer/services/comlink/src/controllers/api/v4/height-controller.ts (1)
- 8-13: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
The removal of
rejectRestrictedCountriesmiddleware from the height-controller aligns with the PR's goal. Verify that this change does not introduce any security or compliance issues, given the nature of the data being accessed.indexer/services/comlink/src/controllers/api/v4/orderbook-controller.ts (1)
- 13-18: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
Confirmed the removal of the
rejectRestrictedCountriesimport. This change is consistent with the PR's objective to remove geoblocking. Ensure that the removal of this middleware does not affect the integrity or security of the data provided by the orderbook endpoint.indexer/services/comlink/src/controllers/api/v4/candles-controller.ts (1)
- 12-17: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
The removal of
rejectRestrictedCountriesmiddleware from the candles-controller is in line with the PR's objectives. It's important to confirm that this change does not compromise the data's security or accessibility in unintended ways.indexer/services/comlink/src/controllers/api/v4/sparklines-controller.ts (1)
- 21-26: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
The removal of
rejectRestrictedCountriesmiddleware from the sparklines-controller is consistent with the PR's goal of removing geoblocking. Ensure that this change is thoroughly tested to confirm that it does not introduce any unintended access or data integrity issues.indexer/services/comlink/src/controllers/api/v4/trades-controller.ts (1)
- 23-28: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
Confirmed the removal of the
rejectRestrictedCountriesmiddleware and its import from the trades-controller. This change aligns with the PR's objectives. It's crucial to ensure that removing this middleware does not expose the endpoint to compliance or security risks.indexer/services/comlink/src/controllers/api/v4/perpetual-markets-controller.ts (1)
- 25-30: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
The removal of
rejectRestrictedCountriesmiddleware from the perpetual-markets-controller is in line with the PR's objectives. Verify that this change does not introduce any security or compliance issues, given the nature of the data being accessed.indexer/services/comlink/src/controllers/api/v4/compliance-controller.ts (1)
- 17-22: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
Confirmed the removal of the
rejectRestrictedCountriesimport from the compliance-controller. This change is consistent with the PR's objective to remove geoblocking. Ensure that the removal of this middleware does not affect the integrity or security of the compliance checks performed by this endpoint.
dydxwill
changed the title
Changelist
Remove geoblocking from Indexer endpoints:
Test Plan
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.