toggle player by pressing space #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everplays
force-pushed
the
toggle-player-by-pressing-space
branch
from
d519ec4
to
2530311
Compare
everplays
force-pushed
the
toggle-player-by-pressing-space
branch
from
2530311
to
c4da852
Compare
|
Hi @everplays, Thanks very much for taking the time to submit this pull request! I've merged it and will try to push out an update in the near future. There's a few other minor issues I've been meaning to fix for a while. Really glad you find the app useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor thing but I found it useful, hence, sharing it.
P.S. Thanks for the work on the app.
NOTE: please be aware that this change breaks the cmd+left and cmd+right bindings for forward/backward functionality. Hence, it is not a good idea to merge this. I just wanted to share the changes in case someone else was looking for the same.