Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix hostname detection for obscuring FQDN. #2095

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tidux
Copy link

@tidux tidux commented Apr 9, 2022

Description

POSIX or not, the current FQDN detection doesn't work on modern Linux systems. This fixes it as tested on FC35.

Features

Stops leaking my hostname information.

Issues

resolves #2094

hykilpikonna added a commit to hykilpikonna/hyfetch that referenced this pull request Aug 11, 2022
… obscuring FQDN.

Upstream PR: dylanaraps/neofetch#2095
Thanks to @tidux

Co-authored-by: tidux <1330562+tidux@users.noreply.github.com>
@hykilpikonna
Copy link

Thank you for your contribution!

This PR is merged into hyfetch since this repo (dylanaraps/neofetch) seems no longer maintained.

HyFetch is a fork of neofetch with LGBTQ pride flags, but the repo also maintains an updated version of the original neofetch, addressing many pull requests that are not merged in the original repo.

Read the "Running Updated Original Neofetch" section for more info!

@hykilpikonna
Copy link

Just realized a problem... not all linux distros come with the inetutils that provides the hostname command. Maybe we should fall back to using $HOSTNAME if hostname command is not found.

hykilpikonna added a commit to hykilpikonna/hyfetch that referenced this pull request Aug 13, 2022
@hykilpikonna
Copy link

I changed it so that it's compatible with systems without the hostname command. I also replaced cut with parameter expansion

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

title_fqdn switch does nothing
2 participants