Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breaking change note - string attributes no longer implicitly converted #877

Merged

Conversation

IMBurbank
Copy link

Add breaking change note to v2.0.0 - string attributes no longer implicitly converted.

Summary:

Add breaking change note that non-string properties will no longer be converted when saved to a string attribute.

For example, a mongoose ID object will no longer be automatically converted and saved as a string.

GitHub linked issue:

Closes #870

#---

Type (select 1):

  • Bug fix
  • Feature implementation
  • Documentation improvement
  • Testing improvement
  • Test added to report bug (GitHub issue #--- @---)
  • Something not listed here

Is this a breaking change? (select 1):

  • 🚨 YES 🚨
  • No
  • I'm not sure

Is this ready to be merged into Dynamoose? (select 1):

  • Yes
  • No

Are all the tests currently passing on this PR? (select 1):

  • Yes
  • No

Other:

  • I have read through and followed the Contributing Guidelines
  • I have searched through the GitHub pull requests to ensure this PR has not already been submitted
  • I have updated the Dynamoose documentation (if required) given the changes I made
  • I have added/updated the Dynamoose test cases (if required) given the changes I made
  • I have ensured the following commands are successful from the root of the project directory
    • npm test
    • npm run lint
  • I agree that all changes made in this pull request may be distributed and are made available in accordance with the Dynamoose license
  • All of my commits and commit messages are detailed, explain what changes were made, and are easy to follow and understand
  • I have filled out all fields above

@vercel
Copy link

vercel bot commented May 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/dynamoose/dynamoose/c2twys4dd
✅ Preview: https://dynamoose-git-fork-imburbank-breaking-tostring-conversion.dynamoose.now.sh

@fishcharlie fishcharlie merged commit 5a6e5fc into dynamoose:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QUESTION] Possible undocumented breaking change - automatic mongooseId object toString() conversion
2 participants