Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standards #10

Closed
chrisdothtml opened this issue Apr 4, 2017 · 4 comments
Closed

Standards #10

chrisdothtml opened this issue Apr 4, 2017 · 4 comments

Comments

@chrisdothtml
Copy link

chrisdothtml commented Apr 4, 2017

I have quite a bit of experience maintaining projects and repos, and have a few notes:

1. Code style

Please follow the coding styles throughout the project

isn't going to do when you have multiple people contributing. You need to decide on a linting tool/style framework and enforce it as part of the build or test process (I use StandardJS).

2. Yarn

Use it. Much faster and more reliable than npm

3. Dependency Management

Dependencies can get out of hand quickly. It's always best to introduce a new dependency only when you need to. Obviously frameworks, etc. are inevitable, but try to be frugal with adding new dependencies; and always remove dependencies if they're not used anymore

4. CI

Travis checks and / or tests?

I'm willing to PR with some/all of these updates, but they should be agreed on beforehand

@AppleBetas
Copy link

Once we're ready for launch we'll look into these more

@itsmehemant123
Copy link

👍🏻

@nullpixel
Copy link
Contributor

Joel#7453 is working on reworking clientside js, and is adding things like an eslint config. Once this is done, I will write up a set of guidelines.

@nullpixel nullpixel mentioned this issue Apr 23, 2017
Closed
@nullpixel nullpixel modified the milestone: Stable Release May 1, 2017
nullpixel added a commit that referenced this issue Jul 9, 2017
- Added and configured eslint
- We now prefer Yarn to manage deps
- CI 🤖
- Add signups ratelimits back
@nullpixel
Copy link
Contributor

Took me a while to get this out, but it's here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants