Skip to content

default to Unit.UNRECOGNIZED if unit is not present in Enum. #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

default to Unit.UNRECOGNIZED if unit is not present in Enum. #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion dynatrace/environment_v2/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ class Unit(Enum):
RATIO = "Ratio"
SECOND = "Second"
STATE = "State"
UNRECOGNIZED = "Unrecognized"
UNSPECIFIED = "Unspecified"
WEEK = "Week"
YEAR = "Year"
Expand Down Expand Up @@ -227,9 +228,13 @@ def _create_from_raw_data(self, raw_element):
self.root_cause_relevant: Optional[bool] = raw_element.get("rootCauseRelevant")
self.tags: Optional[List[str]] = raw_element.get("tags")
self.transformations: Optional[List[Transformation]] = [Transformation(element) for element in raw_element.get("transformations", [])]
self.unit: Optional[Unit] = Unit(raw_element.get("unit")) if raw_element.get("unit") else None
self.warnings: Optional[List[str]] = raw_element.get("warnings")

# any metrics with a custom unit (not present in the Enum) will be set to 'Unrecognized'.
try:
self.unit: Optional[Unit] = Unit(raw_element.get("unit")) if raw_element.get("unit") else None
except ValueError:
self.unit = Unit.UNRECOGNIZED

class ValueType(Enum):
ERROR = "error"
Expand Down