Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode build is broken #189

Closed
zedaav opened this issue Feb 6, 2024 · 2 comments
Closed

VSCode build is broken #189

zedaav opened this issue Feb 6, 2024 · 2 comments
Labels
bug Something isn't working plugin:vscode VsCode plugin related issue

Comments

@zedaav
Copy link
Contributor

zedaav commented Feb 6, 2024

see https://code.visualstudio.com/docs/python/environments#_environment-variable-definitions-file
and https://github.com/microsoft/vscode-python/wiki/Activate-Environments-in-Terminal-Using-Environment-Variables

First problem: python venv is now loaded before build commands are issued. And buildenv refuses to run since already executed from a venv.

Second problem: activation scripts are not executed anymore, so it breaks the buildenv paradigm. Typically completion setup is not executed, etc...

@zedaav zedaav added bug Something isn't working plugin:vscode VsCode plugin related issue labels Feb 6, 2024
@zedaav
Copy link
Contributor Author

zedaav commented Feb 6, 2024

Terminal settings should be updated to get something like this (for each supported shell):

    "terminal.integrated.profiles.linux": {
        "bash": {
            "args": [
                "--init-file",
                ".buildenv/shell.sh"
            ]
        },
    },

Tasks should be updated to directly call nmk instead of buildenv. Except for setup, which should run buildenv init instead

@zedaav
Copy link
Contributor Author

zedaav commented Feb 10, 2024

See also how to integrate vscode shell script
https://code.visualstudio.com/docs/terminal/shell-integration
Maybe in another buildenv extension?

zedaav added a commit to dynod/nmk-vscode that referenced this issue Feb 11, 2024
zedaav added a commit to dynod/nmk-vscode that referenced this issue Feb 18, 2024
zedaav added a commit to dynod/nmk-vscode that referenced this issue Feb 18, 2024
zedaav added a commit to dynod/nmk-vscode that referenced this issue Feb 19, 2024
zedaav added a commit to dynod/nmk-vscode that referenced this issue Feb 19, 2024
zedaav added a commit to dynod/nmk-vscode that referenced this issue Feb 19, 2024
zedaav added a commit to dynod/nmk-vscode that referenced this issue Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin:vscode VsCode plugin related issue
Projects
None yet
Development

No branches or pull requests

1 participant