Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[log] Support log to file #8

Closed
2 of 6 tasks
at15 opened this issue Mar 28, 2017 · 1 comment
Closed
2 of 6 tasks

[log] Support log to file #8

at15 opened this issue Mar 28, 2017 · 1 comment
Labels
Milestone

Comments

@at15
Copy link
Member

at15 commented Mar 28, 2017

Currently stdout is the only output, I don't think it even writes any thing to stderr, though 12 factors strongly discourage log to file and suggest using redirect, but I find logging to file with default naming is pretty useful, especially when you log a lot and you can't scroll up the terminal any more.

@at15 at15 added this to the 0.0.1 milestone Mar 28, 2017
@at15 at15 modified the milestones: 0.0.2, 0.0.1 Jul 8, 2017
@at15 at15 added the pkg/log label Sep 16, 2017
@at15 at15 modified the milestones: 0.0.2, future Feb 1, 2018
@at15 at15 modified the milestones: future, 0.0.8 Sep 6, 2018
@at15
Copy link
Member Author

at15 commented Nov 26, 2018

just use a file as io.Writer and pass to handlers, it's already implemented long time ago

add Flush on Logger maybe we should have a FlushAll due to tree of logger #33

log rotate is not supported, might put that in logx

@at15 at15 closed this as completed Nov 26, 2018
at15 added a commit that referenced this issue Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant